Add support for "application/*+x-protobuf" media type #34645
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
Signed-off-by: Kamil Doroszkiewicz <[email protected]>
doroszkiewicz
force-pushed
the
protobuf-plus-media-type
branch
from
f19ec86 to
e8af432
Compare
bclozel
added
in: web
bclozel
pushed a commit
that referenced
this pull request
Jun 5, 2025
See gh-34645 Signed-off-by: Kamil Doroszkiewicz <[email protected]>
|
Thanks @doroszkiewicz and congrats on your first contribution! |
bclozel
changed the title
bclozel
pushed a commit
that referenced
this pull request
Jun 16, 2025
See gh-34645 Closes gh-35062 Signed-off-by: Johnny Lim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to version our API using protobuf. I added support for versioning via the media type header. The solution is analogous to versioning the JSON format.
Example header supported by this change:
application/vnd.examle.public.v1+x-protobuf